Assigned job slots and cryorines. #4076
Merged
+22
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segrain
added
Testmerge Candidate
Segrain
added
Test Merge Only
3 tasks
3 tasks
Segrain
removed
Test Merge Only
harryob
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Followup to #3552. In other words, the second part of it that was left out of the original PR to cut down on feature creep.
Seems to work out fine in first approach on localhost, but testing with wider populace in natural conditions is probably required.
(Also, added an extra sanity check to keep randomised characters from inheriting actual characters' records which might be using the actual names - not that anybody ever reads character records anyawy.)
Explain why it's good for the game
Roleplaying game letting players use their characters is good. Encouraging players to use different characters more is also good.
Changelog
🆑
add: Joining cryomarines now uses your assigned character slot for the role you get (as long as you have not already used that character name this round).
/:cl: